Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

size-label action fails all PRs #1785

Closed
pcj opened this issue Mar 17, 2021 · 1 comment · Fixed by #1786
Closed

size-label action fails all PRs #1785

pcj opened this issue Mar 17, 2021 · 1 comment · Fixed by #1786

Comments

@pcj
Copy link
Member

pcj commented Mar 17, 2021

@alexeagle The size-label github action does not appear to work with pull requests. It appears to immediately fail I think due to the GITHUB_TOKEN permissions.

Ref: #1782 (your PR) and #1784 (mine)
@gravypod gravypod linked a pull request Mar 17, 2021 that will close this issue
Revert "Setup assign-size-label action" #1786
Merged
@gravypod
Copy link
Collaborator

I've setup a revert PR. If someone knows a better solution that would be preferable. I think it's a nice to have feature but I'd rather disable it than opening up a possible security risk or something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Revert "Setup assign-size-label action" bazelbuild/rules_docker
2 participants
@pcj @gravypod