Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

container_image rules don't take into account the architecture of underlying container_import #2055

Closed
dastbe opened this issue Apr 9, 2022 · 2 comments
Labels
Can Close? Will close in 30 days unless there is a comment indicating why not

Comments

@dastbe
Copy link

dastbe commented Apr 9, 2022

🐞 bug report

Affected Rule

container_image, but also the associated language rules

Is this a regression?

In some sense yes, as pre-transition rules you could control this centrally

Description

With the implementation of image transition logic, it's now the case that the architecture/operating system of the container_image rule are used to transition build configuration to build for that image. However, two primary problems

  1. most lang rules don't even support wiring this through, so regardless of what you want it will default to amd64/linux
  2. there's no guarantee that the underlying container_import's arch/os are aligned with the container_image's output arch/os

so while the image transition rules are really good for "ensure the image is built for amd64/linux", they're detrimental to actually building for any other platform.

🔬 Minimal Reproduction

TODO

🔥 Exception or Error






🌍 Your Environment

Operating System:

  
macos, linux
  

Output of bazel version:

  
4.2.3, but not dependent
  

Rules_docker version:

  
0.23
  

Anything else relevant?

@github-actions
Copy link

github-actions bot commented Oct 7, 2022

This issue has been automatically marked as stale because it has not had any activity for 180 days. It will be closed if no further activity occurs in 30 days.
Collaborators can add an assignee to keep this open indefinitely. Thanks for your contributions to rules_docker!

@github-actions github-actions bot added the Can Close? Will close in 30 days unless there is a comment indicating why not label Oct 7, 2022
@github-actions
Copy link

github-actions bot commented Nov 7, 2022

This issue was automatically closed because it went 30 days without a reply since it was labeled "Can Close?"

@github-actions github-actions bot closed this as completed Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Can Close? Will close in 30 days unless there is a comment indicating why not
Projects
None yet
Development

No branches or pull requests

1 participant