Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix minor typo in attribute docs. #3067

Merged
merged 2 commits into from
Feb 13, 2022

Conversation

jeongukjae
Copy link
Contributor

What type of PR is this?

Documentation

What does this PR do? Why is it needed?

Fix minor typos. Actual valid choices for these options are "auto", "on", "off", but the docs says `on`, `on`, or `auto`.

Which issues(s) does this PR fix?

Fixes # Skipping this section.

Other notes for review

I checked the choices of the attrs in below links.

Thanks :)

@robfig
Copy link
Contributor

robfig commented Feb 12, 2022

Interesting, it looks like there's a test for the documentation that needs to be updated?
//docs:docs_go_core_rules-difftest

@jeongukjae
Copy link
Contributor Author

jeongukjae commented Feb 13, 2022

@robfig Oh, thank you :)
I thought this is a just fix for the docs, so I didn't check the test cases. I ran bazel run //docs:update.

It seems all tests are passed now.

@robfig robfig merged commit 0c8636d into bazel-contrib:master Feb 13, 2022
@robfig
Copy link
Contributor

robfig commented Feb 13, 2022

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants