fix(esbuild): fix depending on testonly targets (#2984)

* test(esbuild): test depending on a testonly target

* fix(esbuild): fix depending on testonly targets

packages/esbuild/esbuild.bzl

@@ -406,6 +406,7 @@ def esbuild_macro(name, output_dir = False, splitting = False, **kwargs):
         args_file = "%s.user.args.json" % name
         params_file(
             name = "%s_args" % name,
+            testonly = kwargs.get("testonly", False),
             out = args_file,
             args = [json.encode(args)],
             data = deps + srcs,

packages/esbuild/test/testonly/BUILD.bazel

@@ -0,0 +1,48 @@
+load("//:index.bzl", "generated_file_test", "js_library", "nodejs_binary", "npm_package_bin")
+load("//packages/esbuild:index.bzl", "esbuild")
+
+js_library(
+    name = "lib",
+    srcs = ["lib.jsx"],
+)
+
+js_library(
+    name = "main",
+    testonly = True,
+    srcs = ["main.js"],
+    deps = [":lib"],
+)
+
+esbuild(
+    name = "bundle",
+    testonly = True,
+    args = {
+        "keepNames": True,
+    },
+    entry_point = "main.js",
+    deps = [
+        ":main",
+    ],
+)
+
+nodejs_binary(
+    name = "bin",
+    testonly = True,
+    data = [
+        ":bundle",
+    ],
+    entry_point = "bundle.js",
+)
+
+npm_package_bin(
+    name = "runner",
+    testonly = True,
+    stdout = "out.txt",
+    tool = ":bin",
+)
+
+generated_file_test(
+    name = "test",
+    src = "out.golden.txt",
+    generated = "out.txt",
+)

packages/esbuild/test/testonly/lib.jsx

@@ -0,0 +1 @@
+export const NAME = 'rules_nodejs';

packages/esbuild/test/testonly/main.js

@@ -0,0 +1,3 @@
+import {NAME as name} from './lib';
+
+console.log(name);

packages/esbuild/test/testonly/out.golden.txt

@@ -0,0 +1 @@
+rules_nodejs