Skip to content

Commit

Permalink
fix(docs): stray text in npm_install docs (#3450)
Browse files Browse the repository at this point in the history
"symlink_node_modules is True" doesn't make any sense in this position. I think it was a stray copy and paste from the beginning of the paragraph.
  • Loading branch information
jfirebaugh authored May 12, 2022
1 parent d234328 commit 6d519eb
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 6 deletions.
6 changes: 2 additions & 4 deletions docs/Built-ins.md
Original file line number Diff line number Diff line change
Expand Up @@ -549,8 +549,7 @@ Defaults to `[]`
If symlink_node_modules is True, this attribute is optional since the package manager
will run in your workspace folder. It is recommended, however, that all files that the
package manager depends on, such as `.rc` files or files used in `postinstall`, are added
symlink_node_modules is True so that the repository rule is rerun when any of these files
change.
so that the repository rule is rerun when any of these files change.

If symlink_node_modules is False, the package manager is run in the bazel external
repository so all files that the package manager depends on must be listed.
Expand Down Expand Up @@ -1214,8 +1213,7 @@ Defaults to `[]`
If symlink_node_modules is True, this attribute is optional since the package manager
will run in your workspace folder. It is recommended, however, that all files that the
package manager depends on, such as `.rc` files or files used in `postinstall`, are added
symlink_node_modules is True so that the repository rule is rerun when any of these files
change.
so that the repository rule is rerun when any of these files change.

If symlink_node_modules is False, the package manager is run in the bazel external
repository so all files that the package manager depends on must be listed.
Expand Down
3 changes: 1 addition & 2 deletions internal/npm_install/npm_install.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,7 @@ COMMON_ATTRIBUTES = dict(dict(), **{
If symlink_node_modules is True, this attribute is optional since the package manager
will run in your workspace folder. It is recommended, however, that all files that the
package manager depends on, such as `.rc` files or files used in `postinstall`, are added
symlink_node_modules is True so that the repository rule is rerun when any of these files
change.
so that the repository rule is rerun when any of these files change.
If symlink_node_modules is False, the package manager is run in the bazel external
repository so all files that the package manager depends on must be listed.
Expand Down

0 comments on commit 6d519eb

Please sign in to comment.