fix(rollup): include externals config in worker cache key

bazel-contrib · Mar 7, 2021 · de9dd86 · de9dd86
1 parent 7f81e5d
commit de9dd86
Showing 1 changed file with 10 additions and 1 deletion.
diff --git a/packages/rollup/index.js b/packages/rollup/index.js
@@ -82,7 +82,16 @@ async function runRollup(cacheKeyData, inputOptions, outputOptions) {
 async function runRollupBundler(args /*, inputs */) {
   const {inputOptions, outputOptions} = await parseCLIArgs(args);
 
-  return runRollup(inputOptions.input, inputOptions, outputOptions);
+  const cacheKeyData = [
+    inputOptions.input,
+
+    // Include changes to externals in the cache key because rollup currently
+    // ignores such changes when using the caching API
+    // See https://github.com/rollup/rollup/issues/3874
+    inputOptions.external
+  ];
+
+  return runRollup(cacheKeyData, inputOptions, outputOptions);
 }
 
 // Processing of --environment CLI options into environment vars