Terser sourcemap support #1195
Merged
Terser sourcemap support #1195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregmagolan
force-pushed
the
terser_sourcemap_support
branch
from
4592fbe
to
5f2aa72
Compare
alexeagle
approved these changes
Sep 26, 2019
| @@ -40,7 +40,7 @@ Can be a .js file, a rule producing .js files as its default output, or a rule p | |||
|
|
|||
| Note that you can pass multiple files to terser, which it will bundle together. | |||
| If you want to do this, you can pass a filegroup here.""", | |||
| allow_files = [".js"], | |||
| allow_files = True, | |||
There was a problem hiding this comment.
why not continue to constrain it? do we no longer have a list of file extensions that should be legal?
There was a problem hiding this comment.
It could be constrained to .js and .mjs and .map I suppose and that would be fine. Should I change it to that?
There was a problem hiding this comment.
I'll change it to that
| def _filter_js(files): | ||
| return [f for f in files if f.is_directory or f.extension == "js" or f.extension == "mjs"] | ||
|
|
||
| def _filter_sourcemap(files): |
There was a problem hiding this comment.
nit: I don't feel like this function is carrying its weight, simple enough list comprehension to inline?
gregmagolan
force-pushed
the
terser_sourcemap_support
branch
2 times, most recently
from
fbb0b53
to
43bb384
Compare
gregmagolan
force-pushed
the
terser_sourcemap_support
branch
from
43bb384
to
5dcfff5
Compare
Toxicable
pushed a commit
to Toxicable/rules_nodejs
that referenced
this pull request
Oct 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.