Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(esbuild): 'output' is passed twice when used #2587

Merged
merged 1 commit into from
Apr 6, 2021

Conversation

mattsoulanille
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features): N/A

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature (please, look at the "Scope of the project" section in the README.md file)
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

When passing 'output', esbuild throws Error in esbuild: rule(...) got multiple values for parameter 'output'

Issue Number: N/A

What is the new behavior?

Fix esbuild_macro always passing the 'output' argument as generated by the rule's name even when the user provides their own 'output' argument.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

I think there may also be a bug with 'output_map' since as far as I can tell, esbuild doesn't let you specify the output file for the sourcemap and always bases it off of the output file's name. Perhaps it shouldn't be an argument to the rule.

Fix esbuild_macro always passing the 'output' argument as generated by the rule's name even when the user provides their own 'output' argument.
@alexeagle alexeagle merged commit 57218a6 into bazel-contrib:stable Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants