Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(builtin): don't restart npm_install rule just to look up a label #2621

Merged
merged 1 commit into from
Apr 22, 2021
Merged

fix(builtin): don't restart npm_install rule just to look up a label #2621

merged 1 commit into from
Apr 22, 2021

Conversation

alexeagle
Copy link
Collaborator

Fixes #2620

@google-cla google-cla bot added the cla: yes label Apr 22, 2021
@alexeagle alexeagle merged commit 16d3a25 into bazel-contrib:stable Apr 22, 2021
twheys pushed a commit to twheys/rules_nodejs that referenced this pull request Jan 13, 2022
@alexeagle @twheys
fix(builtin): don't restart npm_install rule just to look up a label (b…
a37385c 
…azel-contrib#2621)

Fixes bazel-contrib#2620
@Silic0nS0ldier Silic0nS0ldier mentioned this pull request Aug 25, 2022
Closed
@mattem mattem mentioned this pull request May 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattem mattem mattem approved these changes

@gregmagolan gregmagolan Awaiting requested review from gregmagolan gregmagolan is a code owner

@soldair soldair Awaiting requested review from soldair

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

npm_install runs three times on a clean build
2 participants
@alexeagle @mattem