Usability: no validation that pkg_npm#package_name matches package.json#name #2782
Assignees
Comments
alexeagle
added a commit
to alexeagle/rules_nodejs
that referenced
this issue
Jun 21, 2021
Currently just validates that the package_name attribute matches the name in package.json (if there is one) Fixes bazel-contrib#2782
alexeagle
added a commit
that referenced
this issue
Jun 21, 2021
Currently just validates that the package_name attribute matches the name in package.json (if there is one) Fixes #2782
alexeagle
added a commit
that referenced
this issue
Jun 21, 2021
Currently just validates that the package_name attribute matches the name in package.json (if there is one) Fixes #2782
twheys
pushed a commit
to twheys/rules_nodejs
that referenced
this issue
Jan 13, 2022
Currently just validates that the package_name attribute matches the name in package.json (if there is one) Fixes bazel-contrib#2782
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Our intent with the
package_nameattribute on pkg_npm is so that our analysis phase can know this info without having to read the package.json file, which we can do only inside an action during the execution phase.However it's easy for users to trip on this. In particular in pairing with @Smokrow just now, we didn't have the
package_nameattribute defined at all, silently making this package not linkable (it didn't provide LinkablePackageInfo)The text was updated successfully, but these errors were encountered: