fix: don't link runfiles node_modules to execroot node_modules if there is an external workspace node_modules #3060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregmagolan
requested review from
alexeagle,
mattem and
soldair
as code owners
…re is an external workspace node_modules
gregmagolan
force-pushed
the
dont_link_from_runfiles_to_execroot_root
branch
from
efcb4b9
to
7ddcc84
Compare
alexeagle
approved these changes
Nov 4, 2021
alexeagle
pushed a commit
that referenced
this pull request
Dec 3, 2021
…re is an external workspace node_modules (#3060)
Merged
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up to the linker refactor in 4.4.2 meant to solve an issue with ibazel and the linker.
Bazel will delete the root execroot node_modules symlink on rebuild in the ibazel run context so from runfiles we shouldn't link to there.
cc @mrmeku