fix(runfiles): use normalized paths when guarding runfiles root and node_modules on Windows #3331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ode_modules on Windows
|
Windows CI Failure is already present on stable, not introduced here... |
alexeagle
reviewed
Feb 16, 2022
mistic
force-pushed
the
fix-broken-runfiles-path-on-windows
branch
from
af06993
to
f80bacb
Compare
gregmagolan
approved these changes
Feb 23, 2022
These failures @alexeagle |
|
@alexeagle can we get this one in? 😃 |
|
oops sorry it missed today's release!! we finally greened up HEAD again... |
|
@alexeagle do you think we can backport this into 4.x? I think it is important to have that fix there too. |
|
sure can you send a PR against the 4.x branch? I'll merge and release a patch |
mistic
added a commit
to mistic/rules_nodejs
that referenced
this pull request
Apr 13, 2022
…ode_modules on Windows (bazel-contrib#3331) * fix(runfiles): use normalized paths when guarding runfiles root and node_modules on Windows * refactor(builtin): run new code path only on Windows
|
I've opened the PR 👍 |
alexeagle
pushed a commit
that referenced
this pull request
Apr 25, 2022
… and node_modules on Windows (#3409) * fix(runfiles): use normalized paths when guarding runfiles root and node_modules on Windows (#3331) * fix(runfiles): use normalized paths when guarding runfiles root and node_modules on Windows * refactor(builtin): run new code path only on Windows * chore(builtin): test ci * Revert "chore(builtin): test ci" This reverts commit 8790485. * chore(builtin): cherry-pick 8606c50 * docs(builtin): do not change unnecessary docs for this PR purpose Co-authored-by: Paul Gschwendtner <paulgschwendtner@gmail.com>
alexeagle
pushed a commit
that referenced
this pull request
Apr 25, 2022
… and node_modules on Windows (#3409) * fix(runfiles): use normalized paths when guarding runfiles root and node_modules on Windows (#3331) * fix(runfiles): use normalized paths when guarding runfiles root and node_modules on Windows * refactor(builtin): run new code path only on Windows * chore(builtin): test ci * Revert "chore(builtin): test ci" This reverts commit 8790485. * chore(builtin): cherry-pick 8606c50 * docs(builtin): do not change unnecessary docs for this PR purpose Co-authored-by: Paul Gschwendtner <paulgschwendtner@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfils the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behaviour?
After #3060 being merged in order to fix a linker problem the paths we collecte to guard the
runfilesand therunfiles node_modulesat https://github.com/bazelbuild/rules_nodejs/blob/stable/internal/node/launcher.sh#L237 are crashing the node resolution when running on Windows as it is using non normalized paths.What is the new behaviour?
That PR makes sure we normalize the collected paths on Windows so that we can later build a correct
BAZEL_PATCH_ROOTS.Does this PR introduce a breaking change?
Other information
Closes #3054 and fixes the build node_modules resolutions when on Windows.