fix(builtin): take custom node_repositories value into account when checking if Node version exists for the platform #3339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hecking if Node version exists for the platform
|
Awesome. Thank you. Will this make it to a 5.x.x update? I see it is in 4.6.3 now. |
|
Oh wow I didn't realize we already had an open issue for this. Yes this resolves #2992. Yeah this will make a 5.x release (we always just cut from stable) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When setting
node_repositoriesattribute on thenode_repositoriesrule (well that's kinda confusing), ensure this is taken into account when checking if the requested node version exists for the platform.This can be useful when trying to trick rnj into downloading a different version of Node for a given OS (eg, a newer version of Node on darwin arm64), or when setting this attr to a version of Node that isn't included in the default list of
NODE_VERSIONSyet.