feat(builtin): perform make variable substitution in npm_package_bin env vars #3343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kormide
requested review from
mattem,
gregmagolan and
alexeagle
as code owners
kormide
commented
Feb 25, 2022
| @@ -368,6 +377,7 @@ jasmine_node_test( | |||
| data = [":expand_variables.out"], | |||
| templated_args = [ | |||
| "$(rootpath :expand_variables.out)", | |||
| "$(execpath :expand_variables.out)", | |||
There was a problem hiding this comment.
I decided to also test the $@ expansion for the args and env vars, though it already must work for the test to succeed, so I could leave it out if you prefer 🤷♂️
|
Same 'ol windows failures |
alexeagle
pushed a commit
that referenced
this pull request
Feb 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Additional environment variables supplied to
npm_package_bindo not undergo make variable substitution.What is the new behavior?
Values of env vars now perform make variable substitution.
Does this PR introduce a breaking change?
Other information