Exclude .tmp_git_root from globs #1948
Conversation
|
The only actual change is in |
cameron-martin
force-pushed
the
exclude-git
branch
from
8c3861d
to
18fb4d8
Compare
|
I've split this up, although not sure why the CI is failing. Looks like its trying to build windows targets on linux. |
|
@scentini @krasimirgg The build failures here doesn't make much sense. What is explicitly requesting the following target in this change? |
|
Please don't merge on green CI ( I triggered a rebuild ) as it's not really green, if you look at https://buildkite.com/bazel/rules-rust-rustlang/builds/8831#0188d87a-2695-4598-a8ad-3c8d9581f3e4 the task crashed. |
|
I'm trying to figure out what's going on here. |
|
Current CI run was correct in skipping the incompatible targets; seems like it's coverage that causes issues. |
|
Looks like previous CI run was with Bazel 6.1.2 while my current is with 6.2.1. Release notes for 6.2.0 include changes related with |
This directory contains the original git repo when the crate is from git. Including this directory currently makes these rules re-run whenever the repository rule re-runs, although this is fixed by bazelbuild/bazel#18271. Even after this fix, excluding this directory avoids depending on unnecessary files. Fixes bazelbuild#1927.
cameron-martin
force-pushed
the
exclude-git
branch
from
18fb4d8
to
d3b5a47
Compare
|
@UebelAndre looks like CI has passed now, and I've regenerated the vendored files. |
* Exclude .tmp_git_root from globs This directory contains the original git repo when the crate is from git. Including this directory currently makes these rules re-run whenever the repository rule re-runs, although this is fixed by bazelbuild/bazel#18271. Even after this fix, excluding this directory avoids depending on unnecessary files. Fixes bazelbuild#1927. * Regenerate vendored crates
* Exclude .tmp_git_root from globs This directory contains the original git repo when the crate is from git. Including this directory currently makes these rules re-run whenever the repository rule re-runs, although this is fixed by bazelbuild/bazel#18271. Even after this fix, excluding this directory avoids depending on unnecessary files. Fixes bazelbuild#1927. * Regenerate vendored crates
* Exclude .tmp_git_root from globs This directory contains the original git repo when the crate is from git. Including this directory currently makes these rules re-run whenever the repository rule re-runs, although this is fixed by bazelbuild/bazel#18271. Even after this fix, excluding this directory avoids depending on unnecessary files. Fixes bazelbuild#1927. * Regenerate vendored crates
This directory contains the original git repo when the crate is from git. Including this directory currently makes these rules re-run whenever the repository rule re-runs, although this is fixed by bazelbuild/bazel#18271. Even after this fix, excluding this directory avoids depending on unnecessary files.
Fixes #1927.