-
Notifications
You must be signed in to change notification settings - Fork 434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix code coverage collection. #2001
Conversation
e9ca5ed
to
31c0896
Compare
e456134
to
d15d2f2
Compare
I'm seeing an odd failure on RBE builds. @scentini @meteorcloudy would either of you be able to take a look?
|
/cc @coeuvre any idea? |
5723f6e
to
db08b06
Compare
aed87d0
to
8da20e8
Compare
I've deferred the issue mentioned on #2001 (comment) to #2005 |
Adding @krasimirgg and @scentini to see if I can't get this merged soon for the release 😅 |
I made #2004 as a minor spinoff so there's a unique commit for the change. |
* Minor CI and test cleanup * Bump min tested Bazel version to 5.2.0 * Fix code coverage collection.
* Minor CI and test cleanup * Bump min tested Bazel version to 5.2.0 * Fix code coverage collection.
This change fixes code coverage. Some notable findings as of Bazel 6.2.1.
_collect_cc_coverage
and_lcov_merger
are magic attributes that enable the coverage behavior folks might be familiar with in C++ and other native rules.COVERAGE_OUTPUT_FILE
in_collect_cc_coverage
tools. This value appears to only be intended for_lcov_merger
tools. Instead, write toCOVERAGE_DIR
..dat
extension.Additionally this bumps the min tested version to avoid the following error: