Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scalatest 3.x.x support? #275

Open
azymnis opened this issue Sep 11, 2017 · 3 comments
Open

scalatest 3.x.x support? #275

azymnis opened this issue Sep 11, 2017 · 3 comments

Comments

@azymnis
Copy link
Contributor

azymnis commented Sep 11, 2017

Package scio_test depends on scalatest 3.x.x which means that it won't work off the box with scala_test rules. Is there any plan to upgrade this rule to use the new version of scalatest? I could pick it up if no one else is working on it.

@johnynek
Copy link
Member

We do this internally this way;

Add these to WORKSPACE

bind(name = 'io_bazel_rules_scala/dependency/scalatest/scalatest', actual = '//3rdparty/jvm/org/scalatest')

In fact we also do this with thrift.

# Here we set up the bindings to the jars the thrift rules need
# this must come after we load all the dependencies
# this replaces what would be called here:
# https://github.com/bazelbuild/rules_scala/blob/692a867a1f65f61c1a92fad6884ee7c414095c82/twitter_scrooge/twitter_scrooge.bzl#L9
bind(name = 'io_bazel_rules_scala/dependency/thrift/libthrift', actual = '@org_apache_thrift_libthrift//jar')
bind(name = 'io_bazel_rules_scala/dependency/thrift/scrooge_core', actual = '@com_twitter_scrooge_core_2_11//jar')
bind(name = 'io_bazel_rules_scala/dependency/thrift/scrooge_generator', actual = '@com_twitter_scrooge_generator_2_11//jar')
bind(name = 'io_bazel_rules_scala/dependency/thrift/util_core', actual = '@com_twitter_util_core_2_11//jar')
bind(name = 'io_bazel_rules_scala/dependency/thrift/util_logging', actual = '@com_twitter_util_logging_2_11//jar')

@johnynek
Copy link
Member

which assumes you have set up //3rdparty/jvm/org/scalatest:scalatest as a target (which we do using the bazel-deps tool: https://github.com/johnynek/bazel-deps

@azymnis
Copy link
Contributor Author

azymnis commented Sep 11, 2017

Got it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants