From cf5adf5473d57cff68718e0c7800fff95e1d732a Mon Sep 17 00:00:00 2001 From: Andy Scott Date: Thu, 1 Mar 2018 12:54:31 -0800 Subject: [PATCH] Compile reporter using very strict settings --- scala/support/BUILD | 18 ++++++++++++++++++ scala/support/JUnitXmlReporter.scala | 5 ++--- 2 files changed, 20 insertions(+), 3 deletions(-) diff --git a/scala/support/BUILD b/scala/support/BUILD index 5663fb7cb..d4d4e786b 100644 --- a/scala/support/BUILD +++ b/scala/support/BUILD @@ -8,4 +8,22 @@ scala_library( '//external:io_bazel_rules_scala/dependency/scala/scala_xml', '//external:io_bazel_rules_scala/dependency/scalatest/scalatest' ], + scalacopts = [ + "-deprecation:true", + "-encoding", "UTF-8", + "-feature", + "-language:existentials", + "-language:higherKinds", + "-language:implicitConversions", + "-unchecked", + "-Xfatal-warnings", + "-Xlint", + "-Yno-adapted-args", + "-Ywarn-dead-code", + "-Ywarn-numeric-widen", + "-Ywarn-value-discard", + "-Xfuture", + "-Ywarn-unused-import", + "-Ypartial-unification", + ] ) diff --git a/scala/support/JUnitXmlReporter.scala b/scala/support/JUnitXmlReporter.scala index 10ede8df4..a90ab2d34 100644 --- a/scala/support/JUnitXmlReporter.scala +++ b/scala/support/JUnitXmlReporter.scala @@ -22,7 +22,6 @@ import java.io.PrintWriter import java.net.InetAddress import java.net.UnknownHostException import java.text.SimpleDateFormat -import java.util.Enumeration import java.util.Properties import scala.collection.mutable.ListBuffer import scala.xml @@ -360,10 +359,10 @@ class JUnitXmlReporter extends Reporter { "\n" + withCDATA } - def xmlify(suites: Iterable[Testsuite]): scala.xml.Elem = + private def xmlify(suites: Iterable[Testsuite]): scala.xml.Elem = { suites.map(xmlify) } - def xmlify(testsuite: Testsuite): scala.xml.Elem = + private def xmlify(testsuite: Testsuite): scala.xml.Elem =