Delete deprecated swift proto library rules #1193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AttilaTheFun
requested review from
BalestraPatrick,
brentleyjones,
keith,
luispadron,
mattrobmattrob and
thii
as code owners
brentleyjones
changed the title
luispadron
approved these changes
Apr 15, 2024
|
There are some conversations happening in Slack related to how easy it is to migrate. I want those to resolve before I approve this. |
mattrobmattrob
approved these changes
Apr 18, 2024
There was a problem hiding this comment.
AFAIK we are in a good place to merge this from the Slack conversations. It would be nice to use an RC approach to get more general feedback to those not following in Slack for the next release given the substantial removal. 👍
Thanks for getting this all through, @AttilaTheFun!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the addition of
swift_proto_library_group, consumers of the deprecatedswift_proto_libraryandswift_grpc_libraryrules now have a clear migration path to the new rules. Given that we will be cutting a source-breaking rules_swift version 2.0 soon, this is a good opportunity to delete the old rules.We will keep the deprecated rules indefinitely in 1.x, and only the new rules will exist in 2.x.
The release notes will also be useful to make consumers aware of the new rules who might not have used the old ones previously due to their inflexibility.