Factor out -index-ignore-system-modules into a separate feature
#1252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brentleyjones
requested review from
BalestraPatrick,
keith,
luispadron,
mattrobmattrob and
thii
as code owners
The feature has opposite polarity to the compiler flag, as we want it to be off by default and only enabled on certain targets. PiperOrigin-RevId: 467693984 (cherry picked from commit 14e066f) --- Cherry-pick notes: We already had this flag, just named the opposite way. Not worth the breaking change to rename it. Though we are now enabling the flag by default. Signed-off-by: Brentley Jones <github@brentleyjones.com>
brentleyjones
force-pushed
the
bj/factor-out-index-ignore-system-modules-into-a-separate-feature
branch
from
3f6d335 to
133c057
Compare
brentleyjones
referenced
this pull request
Jun 21, 2024
The feature has opposite polarity to the compiler flag, as we want it to be off by default and only enabled on certain targets. PiperOrigin-RevId: 467693984
luispadron
approved these changes
Jun 21, 2024
brentleyjones
deleted the
bj/factor-out-index-ignore-system-modules-into-a-separate-feature
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The feature has opposite polarity to the compiler flag, as we want it to be off by default and only enabled on certain targets.
PiperOrigin-RevId: 467693984
(cherry picked from commit 14e066f)
Cherry-pick notes: We already had this flag, just named the opposite way. Not worth the breaking change to rename it. Though we are now enabling the flag by default.