Fix LLDB expr evaluation for swift_{binary,test} targets only containing Swift in their srcs
#1269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brentleyjones
requested review from
BalestraPatrick,
keith,
luispadron,
mattrobmattrob and
thii
as code owners
brentleyjones
referenced
this pull request
Jun 24, 2024
…ining Swift in their `srcs`. The `.swiftmodule` resulting from compilation of the target's sources was being ignored (since it cannot be a dependency of anything else), but it needs to be embedded as with any other `.swiftmodule` in order for LLDB to find it and initialize the AST context properly. PiperOrigin-RevId: 477544434
…ining Swift in their `srcs` The `.swiftmodule` resulting from compilation of the target's sources was being ignored (since it cannot be a dependency of anything else), but it needs to be embedded as with any other `.swiftmodule` in order for LLDB to find it and initialize the AST context properly. PiperOrigin-RevId: 477544434 (cherry picked from commit c0cdb8b) Signed-off-by: Brentley Jones <github@brentleyjones.com>
brentleyjones
force-pushed
the
bj/cp-c0cdb8b5a2100b3962993654f7409b80f3ce96f2
branch
from
75fb040 to
afff427
Compare
luispadron
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
.swiftmoduleresulting from compilation of the target's sources was being ignored (since it cannot be a dependency of anything else), but it needs to be embedded as with any other.swiftmodulein order for LLDB to find it and initialize the AST context properly.PiperOrigin-RevId: 477544434
(cherry picked from commit c0cdb8b)