Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix usage of params files in _swift_proto_compile #1283

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

bbreier
Copy link
Contributor

@bbreier bbreier commented Jul 2, 2024

I noticed that when I had a long list of deps for a swift_proto_library target, my builds would fail with an error unrecognized argument: --param. This is because protoc expects param files to be prefixed with @ instead of a --param arg. That change + using the multiline file format allows everything to work as intended.

Copy link

google-cla bot commented Jul 2, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@bbreier bbreier force-pushed the bbreier/fix-params-files branch from 84b5827 to 0569ee5 Compare July 2, 2024 19:44
@brentleyjones brentleyjones merged commit 0a4bc19 into bazelbuild:master Jul 3, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants