Simplify swift_library_group
#1292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brentleyjones
requested review from
BalestraPatrick,
keith,
luispadron,
mattrobmattrob and
thii
as code owners
luispadron
approved these changes
Jul 16, 2024
While working on something else I realized that the code for `swift_library_group` was more complex than it needed to be. Signed-off-by: Brentley Jones <github@brentleyjones.com>
brentleyjones
force-pushed
the
bj/simplify-swift_library_group
branch
from
9dc974a to
b6d1624
Compare
tcamin
pushed a commit
to Subito-it/rules_swift
that referenced
this pull request
Sep 10, 2024
While working on something else I realized that the code for `swift_library_group` was more complex than it needed to be. Signed-off-by: Brentley Jones <github@brentleyjones.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on something else I realized that the code for
swift_library_groupwas more complex than it needed to be.