Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Un-conditionalize logic for features that require Xcode 15.0 or higher (dropping support for Xcode 14) #1311

Merged
merged 2 commits into from
Sep 19, 2024

Conversation

luispadron
Copy link
Contributor

@luispadron luispadron commented Sep 18, 2024

PiperOrigin-RevId: 640116533

Cherry picks: f235362

Submitting to the App Store requires Xcode 15+ so this cherry pick (and some other changes to < Xcode 15 logic I made) drops support for Xcodes less than 15

…r (dropping support for Xcode 14).

PiperOrigin-RevId: 640116533
@luispadron luispadron changed the title Luis/cherry pick f235362 Un-conditionalize logic for features that require Xcode 15.0 or higher (dropping support for Xcode 14) Sep 18, 2024
luispadron referenced this pull request Sep 18, 2024
…r (dropping support for Xcode 14).

PiperOrigin-RevId: 640116533
@luispadron luispadron force-pushed the luis/cherry-pick-f235362 branch from 1350b29 to d1a8087 Compare September 18, 2024 23:52
@brentleyjones brentleyjones enabled auto-merge (rebase) September 18, 2024 23:53
@luispadron luispadron force-pushed the luis/cherry-pick-f235362 branch from d1a8087 to 3704684 Compare September 18, 2024 23:54
@luispadron
Copy link
Contributor Author

Seems like a last_green issue, unrelated to this for doc tests:


ERROR: /var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/ec321eb2cc2d0f8f91b676b6d4c66c29/external/rules_java/toolchains/BUILD: no such target '@@rules_java//toolchains:bootstrap_runtime_toolchain_type': target 'bootstrap_runtime_toolchain_type' not declared in package 'toolchains' defined by /var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/ec321eb2cc2d0f8f91b676b6d4c66c29/external/rules_java/toolchains/BUILD
--
  | (23:55:06) ERROR: /var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/ec321eb2cc2d0f8f91b676b6d4c66c29/external/remote_jdk8_macos_aarch64_toolchain_config_repo/BUILD.bazel:27:10: no such target '@@rules_java//toolchains:bootstrap_runtime_toolchain_type': target 'bootstrap_runtime_toolchain_type' not declared in package 'toolchains' defined by /var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/ec321eb2cc2d0f8f91b676b6d4c66c29/external/rules_java/toolchains/BUILD and referenced by '@@remote_jdk8_macos_aarch64_toolchain_config_repo//:bootstrap_runtime_toolchain'
  | (23:55:06) ERROR: /var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/ec321eb2cc2d0f8f91b676b6d4c66c29/external/io_bazel_stardoc/src/main/java/com/google/devtools/build/skydoc/renderer/BUILD:17:12: Analysis failed
  | (23:55:06) ERROR: Analysis of target '//doc:test_api' failed; build aborted: Analysis failed


@brentleyjones brentleyjones merged commit 0c30ead into master Sep 19, 2024
12 of 14 checks passed
@brentleyjones brentleyjones deleted the luis/cherry-pick-f235362 branch September 19, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants