Disable AEGs inside rules which uses swift toolchain from a rule's attribute #1360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tribute These rules should register swift toolchain and then use it inside run_toolchain_action. Until then, AEGs will be disabled. PiperOrigin-RevId: 567330453 (cherry picked from commit 3e50799) Signed-off-by: Brentley Jones <github@brentleyjones.com>
brentleyjones
requested review from
BalestraPatrick,
keith,
luispadron,
mattrobmattrob and
thii
as code owners
brentleyjones
referenced
this pull request
Oct 7, 2024
…tribute These rules should register swift toolchain and then use it inside run_toolchain_action. Until then, AEGs will be disabled. PiperOrigin-RevId: 567330453
luispadron
approved these changes
Oct 7, 2024
brentleyjones
deleted the
bj/disable-aegs-inside-rules-which-uses-swift-toolchain-from-a-rule-s-attribute
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These rules should register swift toolchain and then use it inside run_toolchain_action. Until then, AEGs will be disabled.
PiperOrigin-RevId: 567330453
(cherry picked from commit 3e50799)