Create an empty marker providerSwiftClangModuleAspectInfo
#1379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
that `swift_clang_module_aspect` always returns, so that other aspects can use `required_aspect_providers` to ensure correct ordering of aspect application and thus depend on the `SwiftInfo` provider attached by the aspect without having to unconditionally require it PiperOrigin-RevId: 617942821 (cherry picked from commit f922a1d) Signed-off-by: Brentley Jones <github@brentleyjones.com>
brentleyjones
requested review from
BalestraPatrick,
keith,
luispadron,
mattrobmattrob and
thii
as code owners
brentleyjones
referenced
this pull request
Oct 14, 2024
…swift_clang_module_aspect` always returns, so that other aspects can use `required_aspect_providers` to ensure correct ordering of aspect application and thus depend on the `SwiftInfo` provider attached by the aspect without having to unconditionally require it. PiperOrigin-RevId: 617942821
thii
approved these changes
Oct 14, 2024
brentleyjones
deleted the
bj/create-an-empty-marker-provider-swiftclangmoduleaspectinfo
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
that
swift_clang_module_aspectalways returns, so that other aspects can userequired_aspect_providersto ensure correct ordering of aspect application and thus depend on theSwiftInfoprovider attached by the aspect without having to unconditionally require itPiperOrigin-RevId: 617942821
(cherry picked from commit f922a1d)