Overlapping diagnostics is broken

[jhjourdan]

The "leaves period" in my company is from June, 1st to May, 31st. When I go to the overlapping diagnostics panel, all the leaves starting before June, 1st are shown, even if they end before the May, 31st.

The reason is that the SQL query which is used to show the overlapping leaves is broken:

SELECT CONCAT(users.firstname, ' ', users.lastname) AS user_label,
            contracts.id AS contract_id, contracts.name AS contract_label,
            status.name AS status_label,
            leaves.*,
            REPLACE(contracts.startentdate, '/', '-')
            FROM leaves
            inner join users on leaves.employee = users.id
            inner join contracts on users.contract = contracts.id
            inner join status on status.id = leaves.status
            WHERE leaves.startdate < CAST(CONCAT(YEAR(leaves.enddate), '-', REPLACE(contracts.startentdate, '/', '-')) AS DATE)
            ORDER BY users.id ASC, leaves.startdate DESC

I.e., it checks whether the start date of the leaves begins after the period starting in the current year, which is not at all what we want...