Fix LineEndConcatenation to handle chained concats #1006
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| def terminal_node_is_string_type?(node) | ||
| if node.type == :send | ||
| _, method, arg = *node |
There was a problem hiding this comment.
arg is actually first_arg.
|
@barunio You'll also have to rebase on top of the current |
|
@barunio Ping :-) |
|
Sorry, I got completely busy last week and am on vacation this week. I On Sunday, April 27, 2014, Bozhidar Batsov notifications@github.com wrote:
Barun Singh |
|
@barunio No worries. I've merged your PR manually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where the LineEndConcatenation cop wasn't able to detect or autocorrect multiple offenses for chained string concatenations.