Quote choice is ignored if inside an interpolated string

[jlabarbera11]

This is relative to the StringLiteral cop. When the enforced style for this is set to double_quotes, the string:

"hello#{hash['there']}"

should produce an error, since single quotes were used when not necessary. However, rubocop does not recognize it as such, since 'there' is part of an interpolated string, and thus ignored. This suggests that checking whether or not strings are a part of an ignored node is being done in the wrong place.

[jonas054]

Yes I guess we forgot about this case when implementing StringLiterals. On the other hand I think that even if double_quotes is set, many people would prefer

"hello#{hash['there']}"

over

"hello#{hash["there"]}"

since the latter looks kind of weird. We can even come up with code that looks even stranger with inner double quotes:

"#{s+"}"}"

My suggestion is that we leave the implementation as it is, but add a spec example that demonstrates how this case is handled.
Cc: @bbatsov @yujinakayama

[guilhermesimoes]

Has this been "fixed" in the meantime?

The following code:

"#{systems[0...-1].join(', ')} or #{systems[-1]}"

is yielding the error:

Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

But I don't want to use join(", ").

Like @jonas054 said, I'd definitely prefer

"hello#{hash['there']}"

over

"hello#{hash["there"]}"

Please make this configurable :)

[guilhermesimoes]

Thanks @jonas054! 👍

[guilhermesimoes]

So, I just tried this out and the example previously discussed is not working.

With the configuration:

Style/StringLiterals:
  EnforcedStyle: double_quotes

Style/StringLiteralsInInterpolation:
  EnforcedStyle: single_quotes

And the code:

"hello#{hash['there']}"

An offense is still registered, but it shouldn't.

The issue is with StringLiterals though, not StringLiteralsInInterpolation.

[jonas054]

Yep, still not right. I'll have to fix that.

[guilhermesimoes]

You are restless @jonas054. Thanks once again! 👍

[dpo]

I've been trying to get the same configuration to work. I'm using 0.27.1. When will this be added to the gem?

[bbatsov]

I doubt we'll do a new release before Christmas, but you can build the gem directly from the github master until then.