Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No offense detected on a block that looks wrong #1309

Closed
kathgironpe opened this issue Aug 28, 2014 · 2 comments · Fixed by #1585
Closed

No offense detected on a block that looks wrong #1309

kathgironpe opened this issue Aug 28, 2014 · 2 comments · Fixed by #1585

Comments

@kathgironpe
Copy link

There should be an offense detected here but there it says "no offenses detected."

    devise_parameter_sanitizer.for(:account_update) do
      |u| u.permit(:username, :email, :password, :password_confirmation, :current_password)
    end
@bbatsov
Copy link
Collaborator

bbatsov commented Aug 28, 2014

Yep, we'll have to enhance MultilineBlockLayout to discover such problems.

@kathgironpe
Copy link
Author

@bbatsov great! Thank you!

lumeet added a commit to lumeet/rubocop that referenced this issue Jan 21, 2015
The cop now registers an offense for arguments on a wrong line.
Auto-correction is also applied to these expressions.
bbatsov added a commit that referenced this issue Jan 21, 2015
[Fix #1309] Add argument handling to MultilineBlockLayout
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants