Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

-a/--auto-correct should exit cleanly #1325

Closed
daytonn opened this issue Sep 4, 2014 · 5 comments
Closed

-a/--auto-correct should exit cleanly #1325

daytonn opened this issue Sep 4, 2014 · 5 comments
Assignees
@jonas054

Comments

@daytonn
Copy link

daytonn commented Sep 4, 2014

If I tell rubocop to auto correct, I don't want fixed errors to count against me. This would make auto-linting workflows much smoother.
@bbatsov
Copy link
Collaborator

bbatsov commented Sep 12, 2014

Makes sense to me.

@jonas054 @yujinakayama Are you on board with this suggestion?

@jonas054
Copy link
Collaborator

Yes, only uncorrected errors should count when the exit code is determined.

@jhirn
Copy link

jhirn commented Sep 12, 2014

+1

1 similar comment
@yujinakayama
Copy link
Collaborator

👍

@ghost
Copy link

ghost commented Dec 5, 2014

bump

@jonas054 jonas054 self-assigned this Dec 5, 2014
bbatsov added a commit that referenced this issue Dec 5, 2014
@bbatsov
Merge pull request #1479 from jonas054/1325_exit_code
eb57fa0 
[Fix #1325] Don't consider corrected offenses as failure
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jonas054 jonas054

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@daytonn @yujinakayama @bbatsov @jhirn @jonas054