autocorrect doesn't fully fix if / elsif block indentation

[strongriley]

original:

    street2 = if result[:secondary_address].present?
      result[:secondary_address]
    elsif result[:address2].present?
      if result[:address2] =~ /^\s*(\d+)\s*$/
        "# #{$1}"
      else
        result[:address2]
      end
    end

autocorrected:

    street2 = if result[:secondary_address].present?
                result[:secondary_address]
    elsif result[:address2].present?
                if result[:address2] =~ /^\s*(\d+)\s*$/
                  "# #{Regexp.last_match[1]}"
                else
                  result[:address2]
                end
    end

What I would expect:

    street2 = if result[:secondary_address].present?
                result[:secondary_address]
              elsif result[:address2].present?
                if result[:address2] =~ /^\s*(\d+)\s*$/
                  "# #{Regexp.last_match[1]}"
                else
                  result[:address2]
                end
              end

Version:

rubocop -V
0.26.0 (using Parser 2.2.0.pre.4, running on ruby 1.9.3 x86_64-darwin13.3.0)

[bbatsov]

@jonas054 Would you have a look at this?

[jonas054]

Yes!

[jonas054]

I think there's a reason why we haven't added autocorrect to the EndAlignment cop. It's because it's a lint cop, and the reasoning is that the misindented end could actually be meant to close a different structure than it does. Autocorrecting it could mask another error.

The bad elsif indentation is not even detected. That's a different story.