Delegate cop should ignore class delegation

[mockdeep]

We have code like this:

class MyClass

  def self.do_something(args)
    new.do_something(args)
  end

  def do_something(args)
    ...
  end
end

And we get a delegate violation: Rails/Delegate: Use delegate to define delegations..

[ivanoblomov]

+1

[ghost]

+1, or is there a better practice than using class delegation?

[walterhorstman]

I've just stumbled over the same issue when I write the following code. If the code is wrong, please tell me how to fix it. Else, it might be a new bug, or this one should be reopened.

def self.[](code)
  indexed[code]
end

def self.indexed
  all.index_by(&:code)
end

My goal is to be able to write things like MyClass[:something] instead of MyClass.indexed[:something].

[bbatsov]

This is fixed on master.

[walterhorstman]

Are you sure? I've changed the definition in the Gemfile to use the Github repo and it still occurs.

[bbatsov]

I'm sure we're no longer processing class methods, so I cannot imagine how this can still happen.