Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't print the unrecognized cop warning several times for the same .rubocop.yml #151

Closed
bbatsov opened this issue May 10, 2013 · 1 comment · Fixed by #153
Closed

Don't print the unrecognized cop warning several times for the same .rubocop.yml #151

bbatsov opened this issue May 10, 2013 · 1 comment · Fixed by #153

Comments

@bbatsov
Copy link
Collaborator

bbatsov commented May 10, 2013

Currently the warning is printed once per file which results in RuboCop starting with a bunch of the same warnings:

Warning: unrecognized cop Indentation found in /Users/bozhidar/work/uiapp/.rubocop.yml
Warning: unrecognized cop Indentation found in /Users/bozhidar/work/uiapp/.rubocop.yml
Warning: unrecognized cop Indentation found in /Users/bozhidar/work/uiapp/.rubocop.yml
Warning: unrecognized cop Indentation found in /Users/bozhidar/work/uiapp/.rubocop.yml
Warning: unrecognized cop Indentation found in /Users/bozhidar/work/uiapp/.rubocop.yml
Warning: unrecognized cop Indentation found in /Users/bozhidar/work/uiapp/.rubocop.yml
...

I guess we should simply keep a map of problematic cops and .rubocop.ymls to improve the warnings output.

@jonas054
@jonas054
Copy link
Collaborator

Good idea. I think I have some time now. I'll implement it.

@jonas054 jonas054 mentioned this issue May 11, 2013
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Do more caching to avoid printing same warning many times. jonas054/rubocop
2 participants
@bbatsov @jonas054