Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style/AlignParameters and system #1546

Closed
lloeki opened this issue Dec 31, 2014 · 1 comment
Closed

Style/AlignParameters and system #1546

lloeki opened this issue Dec 31, 2014 · 1 comment

Comments

@lloeki
Copy link
Contributor

lloeki commented Dec 31, 2014

Style/AlignParameters wants to change things this way:

     system "make", "-C", "ace", "-f", "GNUmakefile.ACE",
                    "INSTALL_PREFIX=#{prefix}",
                    "LDFLAGS=",
                    "DESTDIR=",
                    "INST_DIR=/ace",
                    "debug=0",
                    "shared_libs=1",
                    "static_libs=0",
                    "install"
# into
     system "make",
            "-C", "ace", "-f", "GNUmakefile.ACE",
            "INSTALL_PREFIX=#{prefix}",
            "LDFLAGS=",
            "DESTDIR=",
            "INST_DIR=/ace",
            "debug=0",
            "shared_libs=1",
            "static_libs=0",
            "install"

It sounds sensible to have system be a special case. It may apply to more methods than system. I don't know what the best course of action is (special cop? "smart" enforced style?, "any_parameter"?).

@bbatsov
Copy link
Collaborator

bbatsov commented Jan 11, 2015

While I understand your reasoning I don't think we should implement special handling like this for anything. Given the fact that pretty much no Ruby dev env support such indentation in the end you're likely to be its only user. :-)

@bbatsov bbatsov closed this as completed Jan 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants