Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

One-liner semicolon terminating expression claimed as corrected when it's not #1547

Closed
lloeki opened this issue Dec 31, 2014 · 0 comments
Closed

One-liner semicolon terminating expression claimed as corrected when it's not #1547

lloeki opened this issue Dec 31, 2014 · 0 comments
Assignees
@jonas054

Comments

@lloeki
Copy link
Contributor

lloeki commented Dec 31, 2014

Output:

ssdb.rb:79:93: C: [Corrected] Do not use semicolons to terminate expressions.
      Signal.trap("TERM") { system("#{bin}/ssdb-server -d #{HOMEBREW_PREFIX}/etc/ssdb.conf"); exit }
                                                                                            ^
@jonas054 jonas054 self-assigned this Jan 8, 2015
bbatsov added a commit that referenced this issue Jan 8, 2015
@bbatsov
Merge pull request #1556 from jonas054/1547_semicolon_avoided_correction
8192111 
[Fix #1547] Use fail in in Semicolon#autocorrect instead of if
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jonas054 jonas054

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lloeki @jonas054