exclude reader methods that ends with a question mark

[pmenglund]

As attr_reader can't deal with variables ending with '?'

Another possible work around it is to use:
class Foo
attr_reader :empty
alias_method :empty?, :empty
end

[coveralls]

Coverage remained the same when pulling 122e589 on pmenglund:master into 650e402 on bbatsov:master.

[bbatsov]

Personally, I use alias_method in situations like this. That said I'm ok with this addition if it's controlled by a configuration variable. Name it AllowPredicates and set it to false by default.

[coveralls]

Coverage remained the same when pulling 10aa812 on pmenglund:master into 650e402 on bbatsov:master.

[bbatsov]

Something is a predicate method even if allow_predicates is false. For clarity's sake I think the || should not be part of that method.

[bbatsov]

I've done a few changes to that cop to address another issue. Please, rebase your changes on top of the current master.

[bbatsov]

I did the necessary changes myself.

[pmenglund]

Great! I wouldn't have time to get back to this until the weekend...

[bbatsov]

You're welcome :-)