autocorrect creates invalid code on 'or' replacement

[dirkbolte]

With auto-correct, the following code will be corrected into an invalid syntax:

teststring = 'abcdefg'
puts "#{teststring.include? 'a' or teststring.include? 'b'}"

becomes

teststring = 'abcdefg'
puts "#{teststring.include? 'a' || teststring.include? 'b'}"

A possible correction would be:

teststring = 'abcdefg'
puts "#{teststring.include? 'a' || teststring.include?('b')}"

[dirkbolte]

rubocop version is: 0.10.0

[bbatsov]

That's a known problem. Doing the autocorrection correctly is pretty complex, so we took a sneaky shortcut here. Maybe we should drop this particular autocorrection? Or we could simply correct only nodes for which replacing or with || won't break anything.

Maybe @jonas054, @edzhelyov and @yujinakayama have a better solution in mind?

[jonas054]

No I don't have a better solution. We should do as you suggest. But I have a feeling it could be complicated to get it right. In that case we should remove this autocorrection first, and release, then implement an autocorrection of or to || that always works.

[yujinakayama]

For now, I also think we don't have better way.

In the future, I think probably we need to implement some way to handle precedences of Ruby syntax, though I guess it's not easy and requires robust logic.

[edzhelyov]

Currently we have only 3-4 simple auto corrections and I expect to have similar issues.
I propose that we mark the auto-correct option as experimental and try to improve it.
We may try to run the parser again over the corrected files and abort the correction if there are syntax problems.

[bbatsov]

@edzhelyov Makes a good point.

[jonas054]

I'll try to implement something based on what @edzhelyov said.