do not warn if using pattern matching in |a, e|, e.g |a, (digest, ids)|

[404pnf]

I take the advice of rubocop very seriously. But I tend to disagree on situation like this:

    find_duplicate_records.rb:38:3: C: Name reduce arguments |a, e| (accumulator, element).
      db.reduce([]) { |a, (_, ids)|  a << ids if ids.size > 1 ; a }
      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    find_duplicate_records.rb:38:59: C: Do not use semicolons to terminate expressions.
      db.reduce([]) { |a, (_, ids)|  a << ids if ids.size > 1 ; a }

I think by using pattern matching, |a (_, ids)| is better than using |a, e| then call e[1] in the block.

[bbatsov]

Yep, we've forgotten to take this into account. On a somewhat unrelated note - in your particular case you'll be better served by each_with_object.

[404pnf]

Thank you! I love each_with_object, that's the correct way.