double alias problem

[zeroed]

Maybe I've found a bug (?)... it seems that rubocop (version 0.5.0) doesn't like so much a snippet of code like this one:

alias has_foo? foo?
alias has_bar? bar?

I will do a PR...

[bbatsov]

What exactly is the problem? I assume you got two warnings to use alias_method instead.

[zeroed]

I saw something a little less polite:

/usr/local/lib/ruby/gems/2.0.0/gems/rubocop-0.5.0/lib/rubocop/cop/alias.rb:10:in `block in inspect': undefined method `lineno' for "c":String (NoMethodError)
    from /usr/local/lib/ruby/gems/2.0.0/gems/rubocop-0.5.0/lib/rubocop/cop/cop.rb:82:in `block (2 levels) in each'
    from /usr/local/lib/ruby/gems/2.0.0/gems/rubocop-0.5.0/lib/rubocop/cop/cop.rb:82:in `block (2 levels) in each'
...

[zeroed]

This is the spec without the check in alias.rb:

Failures:

  1) Rubocop::Cop::Alias does not mess with double alias
     Failure/Error: inspect_source(a,
     NoMethodError:
       undefined method `lineno' for "s":String
     # ./lib/rubocop/cop/alias.rb:11:in `block in inspect'
     # ./lib/rubocop/cop/cop.rb:82:in `block (2 levels) in each'
     # ./lib/rubocop/cop/cop.rb:82:in `block (2 levels) in each'
     # ./lib/rubocop/cop/cop.rb:80:in `each'
     # ./lib/rubocop/cop/cop.rb:82:in `block in each'
     # ./lib/rubocop/cop/cop.rb:81:in `each'
     # ./lib/rubocop/cop/cop.rb:81:in `each'
     # ./lib/rubocop/cop/cop.rb:82:in `block in each'
     # ./lib/rubocop/cop/cop.rb:81:in `each'
     # ./lib/rubocop/cop/cop.rb:81:in `each'
     # ./lib/rubocop/cop/alias.rb:9:in `inspect'
     # ./spec/rubocop/cops/alias_spec.rb:24:in `block (2 levels) in <module:Cop>'

[bbatsov]

The actual problem here is not that there are two alias keywords, but the use of barewords with them. Since I generally always use symbols I forgot to support that case. Thanks for reporting that!

[zeroed]

You're welcome @bbatsov ... reading the rubocop code is always a pleasure!
^_^

Yup...