Add autocorrect for style cops

[sferik]

Specifically, I noticed the following cops are missing auto-correction:

• NumericLiterals
• WordArray
• AccessModifierIndentation
• SingleLineMethods
• EmptyLineBetweenDefs
• IndentationWidth
• IndentationConsistency
• Proc

There may be others but these are the ones that affect me most frequently. I may contribute some of these patches myself but wanted to open an issue to document the defect. Ideally, after running rubocop --auto-correct, the only remaining offenses be things like ClassLength, MethodLength, CyclomaticComplexity, etc., which cannot be programmatically fixed.

[bbatsov]

Indeed we should autocorrections for all of those. Btw, auto-correction for NumericLiterals was recently added in master. I'll convert the items in your ticket to a list so we can cross them off after they're implemented.

[bbatsov]

@jonas054 @yujinakayama Feel free to add more items to the list. I'm fairly sure there are other cops that are missing auto-correct functionality, for which it's possible to implement it. I guess it might be a good idea to have a table in the wiki that keeps track of this (and possibly other cop features).

[jonas054]

Just off the top of my head, I know that I recently split IndentationWidth into two cops, so I've added IndentationConsistency to the list. Will add more later if I find any.

[jonas054]

I've added a wiki page. Please make additions, deletions and changes as you see fit. It's just my opinions and guesses; something to get a discussion started.

[bbatsov]

@jonas054 Nice work on the wiki page. I guess we should start by implementing auto-correct where it's easier to do so and move to the tougher cases down the road.

[jonas054]

I'll do WordArray.

[jonas054]

I'll do AccessModifierIndentation next.

[jonas054]

I'll do SingleLineMethods next.

[jonas054]

I'll do IndentationWidth and IndentationConsistency next.

[sferik]

I’ve updated this issue with some more candidates for auto-correction.

[jonas054]

Good! I'll try to tackle some of them. Anyone is of course welcome to help out.

[bbatsov]

By the way, I'm not overly fond of long-lived issues with lots of bullets. Tickets with smaller scope are generally easier to track, discuss and close.

[sferik]

Fair enough. I’m happy to close this issue and open new issues for all the unchecked boxes.

[bbatsov]

Great! Let's do this then.