Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exit with exit code 1 if there were errors #1587

Merged
merged 1 commit into from
Jan 21, 2015

Conversation

jonas054
Copy link
Collaborator

This is necessary in order to make errors visible in Travis for example.

There's currently a crash in Style/StructInheritance (just created #1586) but we've missed it because rubocop still exits with 0.

This is necessary in order to make errors visible in Travis
for example.
bbatsov added a commit that referenced this pull request Jan 21, 2015
Exit with exit code 1 if there were errors
@bbatsov bbatsov merged commit 24a120e into rubocop:master Jan 21, 2015
@bbatsov
Copy link
Collaborator

bbatsov commented Jan 21, 2015

👍

@jonas054 jonas054 deleted the fix_exit_code branch January 21, 2015 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants