Return nil from autocorrect? if cop does not support autocorrection #1712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -5,7 +5,9 @@ module Cop | |||
| # This module encapsulates the logic for autocorrect behaviour for a cop | |||
| module AutocorrectLogic | |||
| def autocorrect? | |||
| @options[:auto_correct] && support_autocorrect? && autocorrect_enabled? | |||
| return nil unless support_autocorrect? | |||
There was a problem hiding this comment.
Boolean methods should return either true or false. Returning anything else is unexpected/uncommon.
There was a problem hiding this comment.
Agreed. It did return nil previously though, if the option wasn't given.
|
I will improve it tomorrow. |
| @@ -74,6 +74,60 @@ | |||
| expect(cop.offenses.first.cop_name).to eq('Style/For') | |||
| end | |||
|
|
|||
| describe 'corrected' do | |||
There was a problem hiding this comment.
This description seems a bit misleading to me.
There was a problem hiding this comment.
LOL forgot to change it. Made a better one now.
|
You'll have to rebase. |
true = corrected false = not corrected nil = not applicable (cop cannot autocorrect code)
|
Rebased. |
bbatsov
added a commit
that referenced
this pull request
Mar 18, 2015
Return nil from autocorrect? if cop does not support autocorrection
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More meaningful values of offenses'
correctedattribute:nil— the cop does not support autocorrection at all;false— the cop could autocorrect this offense, but didn't do it for one reason or another;true— the cop has autocorrected this offense.