Keep line breaks in place on WordArray autocorrect #2071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -59,9 +59,21 @@ def word_regex | |||
| cop_config['WordRegex'] | |||
| end | |||
|
|
|||
| def autocorrect_words(word_nodes, base_line_number) | |||
There was a problem hiding this comment.
It's better to make all calls downwards in the file. Put this method after autocorrect.
unmanbearpig
force-pushed
the
style-word-array-line-breaks-fix
branch
from
d216553 to
babd2a0
Compare
I've found a problem that when I have an array of words that spans
multiple lines
```ruby
array = ['first_word', 'second_word', 'third_word', 'fourth_word',
'fifth_word', 'sixth_word', 'seveth_word']
```
Autocorrect replaces it with %w() syntax, which is fine, but it also
removes all of the line breaks, which makes the line too long and forces
me to fix it manually.
I've made Syntax/WordArray take into account existing line breaks when
it autocorrects it.
unmanbearpig
force-pushed
the
style-word-array-line-breaks-fix
branch
from
babd2a0 to
3c8979a
Compare
|
Thanks for feedback, I've fixed it and added a note to the changelog. |
bbatsov
added a commit
that referenced
this pull request
Jul 26, 2015
…ks-fix Keep line breaks in place on WordArray autocorrect
|
👍 Looks good. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've found a problem that when I have an array of words that spans
multiple lines
Auto-correct replaces it with %w() syntax, which is fine, but it also
removes all of the line breaks, which makes the line too long and forces
me to fix it manually.
I've made Syntax/WordArray take into account existing line breaks when
it auto-corrects it.