Fix EmptyLinesAroundBody so it doesn't report blank lines. #748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That is, lines with only space. The TrailingSpace cop must do its job first. Then we can deal with the extra empty line in EmptyLinesAroundBody. Otherwise auto-correction doesn't work.
bbatsov
added a commit
that referenced
this pull request
Jan 20, 2014
Fix EmptyLinesAroundBody so it doesn't report blank lines.
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves a conflict ("clobbering") between
EmptyLinesAroundBodyandTrailingWhitespace. An extra blank line containing whitespace would cause them to try to remove the same characters in--auto-correct. The solution is to divide the offences between them.EmptyLinesAroundBodydoesn't report offences for lines containing spaces now.