Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

failing test case for StringConversionInInterpolation #952

Closed
wants to merge 1 commit into from
Closed

failing test case for StringConversionInInterpolation #952

wants to merge 1 commit into from

Conversation

tamird
Copy link
Contributor

@tamird tamird commented Apr 3, 2014

@bbatsov looks like another bug

@tamird
Copy link
Contributor Author

tamird commented Apr 3, 2014

Maybe this test case isn't quite right, and it should report a violation (indicating self should be used instead). Feel free to change. Still, it currently just throws an exception.

@bbatsov
Copy link
Collaborator

bbatsov commented Apr 4, 2014

It's a bug, indeed. Thanks for reporting it.

@bbatsov bbatsov closed this in 610633d Apr 4, 2014
@bbatsov
Copy link
Collaborator

bbatsov commented Apr 4, 2014

Opted to replace to_s with self in such scenarios. The resulting code is clearer IMO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tamird @bbatsov