Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

npm audit fails on bbc-a11y because of jquery vulnerability #1625

Closed
1 task done
pjlee11 opened this issue Apr 23, 2019 · 1 comment · Fixed by #1655
Closed
1 task done

npm audit fails on bbc-a11y because of jquery vulnerability #1625

pjlee11 opened this issue Apr 23, 2019 · 1 comment · Fixed by #1655
Assignees
@pjlee11
Labels
a11y Accessibility-related task bug Something isn't working

Comments

@pjlee11
Copy link
Contributor

pjlee11 commented Apr 23, 2019 •
edited
Loading

Describe the bug
A vulnerability in bbc-a11y has broken our deployment lifecycle due to us needing audit-ci -low to pass before we can deploy.

image

See bbc/bbc-a11y#289

Solution
Once bbc/bbc-a11y#289 has been fixed and published we need to pull in the new version of bbc-a11y.

Testing

Dev insight: we should be able to run npm audit without any failures.

  • Initially labelled with "bug"
@pjlee11 pjlee11 added bug Something isn't working a11y Accessibility-related task simorgh-core-stream labels Apr 23, 2019
@pjlee11 pjlee11 self-assigned this Apr 23, 2019
This was referenced Apr 23, 2019
Merged
Merged
@sareh
Copy link
Contributor

sareh commented Apr 24, 2019

After the bbc-a11y fix has been published, we should pull in that change and also remove the --whitelist jquery added in this PR: #1632

@pjlee11 pjlee11 mentioned this issue Apr 29, 2019
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pjlee11 pjlee11

Labels
a11y Accessibility-related task bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bump bbc a11y remove vuln exception bbc/simorgh
2 participants
@sareh @pjlee11