-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nomad should unregsiter the signal handlers #79
Comments
Watching |
@SobhanMP what operating system are you using? |
i use linux |
When you comment the
/** Step::userInterrupt() will be called if CTRL-C is pressed.
|
yep, it took a bit of effort to build it but yeah. Also i noticed that NOMAD_jll (the nomad build) is very outdated. |
@SobhanMP |
Would it be a simple pull request for https://github.com/JuliaPackaging/Yggdrasil/blob/b63bb8b3553d614d20a95137528de1ae506fbef8/N/NOMAD/build_tarballs.jl |
No, because the headers are generated dynamically and I need to generate a new patch for each new release. |
it also seems tha SGTE got deprecated(?) but is that patch really needed? the second part of the patch fails (and atomic_patch ignores it as far as i understand)
this does nothing just removes trailing space
option to disable openmp was added so no need
same for this
this fails. the rest seems to be a bunch of custom configs that was added but i'm not sure why. a bunch of the configs are now deprecated. Maybe it's a better idea to take the python route and not put a struct for anything and let the user configure everything with the nomad original keywords instead of a struct? |
In an attempt to fix NOMAD.jl (the threading issue), i realized that nomad never releases the signal handlers. Mark Kittisopikul and i think that might be the issue. Would it be possible to restore the original signal handlers? or even better have an option to not catch them at all in the library mode? specifically the sigev signal handler breaks julia as julia also catches the sigev signal.
ref bbopt/NOMAD.jl#39
The text was updated successfully, but these errors were encountered: