Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(GH-15) Documentation added. #16

Merged
merged 1 commit into from
Nov 20, 2019

Conversation

stefan-lindegger
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Nov 20, 2019

Codecov Report

Merging #16 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           develop   #16   +/-   ##
=====================================
  Coverage       50%   50%           
=====================================
  Files            2     2           
  Lines            8     8           
  Branches         2     2           
=====================================
  Hits             4     4           
  Misses           2     2           
  Partials         2     2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ffa4ad...b18886a. Read the comment docs.

Copy link
Contributor

@marco-bertschi marco-bertschi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General request, apart from the comments: Use backticks in you're referencing API classes and interfaces as this automatically adds a link within the generated content to the API documentation.

docs/input/docs/getting-started/principles.md Show resolved Hide resolved
docs/input/docs/getting-started/whystrategypattern.md Outdated Show resolved Hide resolved
docs/input/docs/getting-started/whystrategypattern.md Outdated Show resolved Hide resolved
docs/input/docs/getting-started/principles.md Outdated Show resolved Hide resolved
docs/input/docs/getting-started/principles.md Outdated Show resolved Hide resolved
docs/input/docs/getting-started/fundamentals.md Outdated Show resolved Hide resolved
docs/input/docs/getting-started/fundamentals.md Outdated Show resolved Hide resolved
docs/input/docs/getting-started/fundamentals.md Outdated Show resolved Hide resolved
docs/input/docs/getting-started/fundamentals.md Outdated Show resolved Hide resolved
docs/input/docs/getting-started/fundamentals.md Outdated Show resolved Hide resolved
@stefan-lindegger stefan-lindegger force-pushed the feature/GH-15 branch 2 times, most recently from a3c2bee to fc3e7ae Compare November 20, 2019 15:20
Copy link
Contributor

@marco-bertschi marco-bertschi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but you need to squash your commits

@pascalberger pascalberger merged commit 9195680 into bbtsoftware:develop Nov 20, 2019
@pascalberger pascalberger mentioned this pull request Nov 20, 2019
bbt-bot pushed a commit that referenced this pull request Nov 20, 2019
Merge pull request #16 from stefan-lindegger/feature/GH-15

(GH-15) Documentation added.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants