Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ReferenceTypeExtensions.AddRangeToCollectionFilterNulvalues should not analyze Expression Tree to find the Add method #36

Closed
marco-bertschi opened this issue Nov 29, 2019 · 1 comment
Closed

ReferenceTypeExtensions.AddRangeToCollectionFilterNulvalues should not analyze Expression Tree to find the Add method #36

marco-bertschi opened this issue Nov 29, 2019 · 1 comment
Labels
Improvement
Milestone
1.0.0

Comments

@marco-bertschi
Copy link
Contributor

Title says it all. Analyzing an expression tree to find a way to add an item to a collection is a very bad idea. We should, if needed, use the corresponding .Net classes to add items anywhere. Might need a bigger refactoring where we only support copying / converting into IList<T>
@marco-bertschi marco-bertschi added this to the 1.0.0 milestone Nov 29, 2019
@marco-bertschi marco-bertschi mentioned this issue Nov 30, 2019
Closed
@marco-bertschi
Copy link
Contributor Author

Closed, is covered by #45

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Improvement
Milestone
1.0.0
Development

No branches or pull requests
1 participant
@marco-bertschi